[8.17](backport #42992) filebeat: make deep copy before notifying of config change#43078
Closed
mergify[bot] wants to merge 1 commit into8.17from
Closed
[8.17](backport #42992) filebeat: make deep copy before notifying of config change#43078mergify[bot] wants to merge 1 commit into8.17from
mergify[bot] wants to merge 1 commit into8.17from
Conversation
This prevents concurrent read & write map access. Unrelated, but I've escalated one log line to Info to allow for easier verifying that ES store is being used from agent logs. Fixes #42815 (cherry picked from commit f1e42fc) # Conflicts: # filebeat/beater/filebeat.go # libbeat/statestore/backend/es/store.go # x-pack/filebeat/tests/integration/managerV2_test.go
Contributor
Author
|
Cherry-pick of f1e42fc has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
This pull request doesn't have a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This prevents concurrent read & write map access.
Unrelated, but I've escalated one log line to
Infoto allow for easier verifying that ES store is being used from agent logs.Fixes #42815
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
This is a blind spot: We have reproduced this on agentless deployments using abusech (see issue). However, I couldn't find a way to reproduce in an integration or unit test.
The closest is this hacky test:
however, that doesn't test any code to be commited
Related issues
Screenshots
Errors stop once the image with the fix is deployed

This is an automatic backport of pull request #42992 done by Mergify.